Update ComponentStatusz milestones and PRR #5611
Conversation
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richabanker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
cc @yongruilin added this just to tackle PRR. |
richabanker
force-pushed
the
statusz-prr
branch
2 times, most recently
from
72ef9b2 to
bf75817
Compare
richabanker
force-pushed
the
statusz-prr
branch
3 times, most recently
from
19abff9 to
6caa731
Compare
richabanker
force-pushed
the
statusz-prr
branch
from
6caa731 to
e9f25d6
Compare
There was a problem hiding this comment.
This LGTM. For 1.36 a PRR file under I don't need to be added here, but I do need to be added as a approver to a file under https://github.com/kubernetes/enhancements/tree/master/keps/prod-readiness corresponding to this KEP. will need to be added corresponding to this KEP. That's what I'll formally approve as PRR reviewer.
richabanker
changed the title
| ###### Will enabling / using this feature result in any new API calls? | ||
| No | ||
| Yes, enabling this feature will result in a new HTTP endpoint (/statusz) being served by each component (including apiserver). However, this is not a Kubernetes API type or resource; it is a non-resource endpoint that provides component status information for debugging and observability. No new Kubernetes API objects or resource types are introduced. |
There was a problem hiding this comment.
IIUC there won't be any new API calls unless a human pings this path (under standardized conditions, these paths shouldn't be machine-consumed, so there won't be any workloads querying this)?
There was a problem hiding this comment.
Because we are introducing a structured api for this endpoint in 1.35, we are essentially allowing for programatic access via those. So we will have both text/plain format (for human access) and json format (for machine access)
There was a problem hiding this comment.
I see, just saw the structured JSON PR and came back here to amend my comment. SGTM.
| - v1.32: New `/statusz` endpoint introduced for [apiserver](https://github.com/kubernetes/kubernetes/pull/125577), | ||
| - v1.33: `/statusz` enablement extended to [kubelet](https://github.com/kubernetes/kubernetes/pull/128811), [scheduler](https://github.com/kubernetes/kubernetes/pull/128987), [controller-manager](https://github.com/kubernetes/kubernetes/pull/128991), and [kube-proxy](https://github.com/kubernetes/kubernetes/pull/128989) | ||
| - v1.34: `/statusz` response enhanced to add a `Paths` field listing down all debug endpoints available for [apiserver](https://github.com/kubernetes/kubernetes/pull/132581) | ||
| - v1.35: `Paths` field added for [kubelet](https://github.com/kubernetes/kubernetes/pull/133239), [scheduler](https://github.com/kubernetes/kubernetes/pull/132606), [controller-manager](https://github.com/kubernetes/kubernetes/pull/133218), and [kube-proxy](https://github.com/kubernetes/kubernetes/pull/133190) |
|
/lgtm Feel free to drop the hold once the linked PR is in. |
k8s-ci-robot
added
the
lgtm
Update ComponentFlagz milestones and PRR #5611
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
4 participants
/hold
for #5560 to be merged first.